[SPARK-16109][SPARKR][DOC] R more doc fixes#13803
[SPARK-16109][SPARKR][DOC] R more doc fixes#13803felixcheung wants to merge 3 commits intoapache:masterfrom
Conversation
|
Test build #60920 has finished for PR 13803 at commit
|
|
Test build #60924 has finished for PR 13803 at commit
|
|
cc @mengxr |
|
@felixcheung Can you change the JIRA in the title to https://issues.apache.org/jira/browse/SPARK-16109 ? I created a sub-task for statfunctions |
| #' occurrences will have zero as their counts. | ||
| #' | ||
| #' @rdname statfunctions | ||
| #' @rdname crosstab |
There was a problem hiding this comment.
can we have a @family stat_functions here to point users to other stat functions ?
|
Other than the comment about the |
|
done - @family doesn't need to be one word so added "stat functions" |
|
Thanks - rebuilt locally and the docs look good. Will merge after Jenkins passes |
|
Test build #60942 has finished for PR 13803 at commit
|
|
LGTM. Merging this |
## What changes were proposed in this pull request? Found these issues while reviewing for SPARK-16090 ## How was this patch tested? roxygen2 doc gen, checked output html Author: Felix Cheung <felixcheung_m@hotmail.com> Closes #13803 from felixcheung/rdocrd. (cherry picked from commit 5774629) Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
|
Great! Thanks! Hopefully now docs are in much better shape. |
|
Yeah - thanks for all the work in cleaning this up. One thing that i was wondering is we could add some style guide checks or contribution guide rules on how to maintain documentation. We can discuss this in SPARK-16090 or in a new JIRA |
|
I have been thinking about the same thing - problem is people generally do not read contribution guide :) if there is a way to get automatic style check it would be good. |
|
Irrespective of people reading the guide, it'll at least be useful to point out what is the expected documentation layout in a code review etc. But yeah automatic style checks would be really cool. |
What changes were proposed in this pull request?
Found these issues while reviewing for SPARK-16090
How was this patch tested?
roxygen2 doc gen, checked output html