[SPARK-16104][SQL] Do not creaate CSV writer object for every flush when writing#13809
Closed
HyukjinKwon wants to merge 7 commits intoapache:masterfrom
Closed
[SPARK-16104][SQL] Do not creaate CSV writer object for every flush when writing#13809HyukjinKwon wants to merge 7 commits intoapache:masterfrom
HyukjinKwon wants to merge 7 commits intoapache:masterfrom
Conversation
| writerSettings.setHeaders(headers: _*) | ||
| writerSettings.setQuoteEscapingEnabled(options.escapeQuotes) | ||
|
|
||
| new CsvWriter(writer, writerSettings) |
Member
Author
There was a problem hiding this comment.
Please let me organise this in a separate class at the PR for refactoring this.
|
Test build #60932 has finished for PR 13809 at commit
|
Member
Author
|
Hm.. I will try to minimise the changes here. |
Member
Author
|
Hi @davies, it seems the past change in your PR is related with this. Could you please take a look? |
|
Test build #60986 has finished for PR 13809 at commit
|
|
Test build #60985 has finished for PR 13809 at commit
|
|
Test build #60988 has finished for PR 13809 at commit
|
Contributor
|
LGTM, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR let
CsvWriterobject is not created for each time but able to be reused. This way was taken after from JSON data source.Original
CsvWriterwas being created for each row but it was enhanced in #13229. However, it still createsCsvWriterobject for eachflush()inLineCsvWriter. It seems it does not have to close the object and re-create this for every flush.It follows the original logic as it is but
CsvWriteris reused by resetingCharArrayWriter.How was this patch tested?
Existing tests should cover this.