SPARK-16178: Remove unnecessary Hive partition check. #13880
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #61139 has finished for PR 13880 at commit
|
| |Requested partitions: ${partition.keys.mkString(",")} | ||
| |Table partitions: ${table.partitionKeys.map(_.name).mkString(",")}""".stripMargin) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
If a user is using SQL, he/she can specify the partition columns. So, this check is still useful (considering that we do not allow to use DataFrameWriter's partitionBy and insertInto together)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This removes a check that partition names match from the Hive write path, which was added as a sanity check in SPARK-14459. The sanity check is incorrect because
partitionBycould be used to explicitly set columns with names that don't match.This is also no longer exercised because of changes in SPARK-16032. Now, Hive's
partitionmetadata is derived from the table partitions during the analysis phase and will always match.