[SQL][minor] Simplify data source predicate filter translation.#13889
Closed
rxin wants to merge 2 commits intoapache:masterfrom
Closed
[SQL][minor] Simplify data source predicate filter translation.#13889rxin wants to merge 2 commits intoapache:masterfrom
rxin wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
cc @yhuai / @liancheng I think you two wrote some of this. |
|
Test build #61167 has finished for PR 13889 at commit
|
Contributor
|
LGTM |
Contributor
|
Merging to master. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a small patch to rewrite the predicate filter translation in DataSourceStrategy. The original code used excessive functional constructs (e.g. unzip) and was very difficult to understand.
How was this patch tested?
Should be covered by existing tests.