[SPARK-16214] [Examples] fix the denominator of SparkPi#13910
[SPARK-16214] [Examples] fix the denominator of SparkPi#13910yanghaogn wants to merge 3 commits intoapache:masterfrom yanghaogn:patch-1
Conversation
|
As the iteration number is n - 1, the denominator would also be n, |
|
Get ready to receive a comment suggesting following https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark.. I believe this is not a
|
|
Nah @HyukjinKwon I think this is a simple fix that's self-contained here. Either the iterations or the estimate formula is wrong here and that's all there is to it. |
|
@yanghaogn since you already made a JIRA, connect it in the title please. It is not resolved |
|
Jenkins test this please |
|
@srowen It's been related now |
|
Not quite, see https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark and other PRs |
|
Test build #61261 has finished for PR 13910 at commit
|
As explained in #2874 ``` The max size of the input seq was Int.MaxValue - 1 ```
|
I see, maybe better to just fix the denominator then. |
change the denominator
|
Jenkins retest this please |
|
Test build #61268 has finished for PR 13910 at commit
|
|
Merged to master/2.0/1.6 |
## What changes were proposed in this pull request? reduce the denominator of SparkPi by 1 ## How was this patch tested? integration tests Author: 杨浩 <yanghaogn@163.com> Closes apache#13910 from yanghaogn/patch-1. (cherry picked from commit b452026) Signed-off-by: Sean Owen <sowen@cloudera.com> (cherry picked from commit 22a496d)
What changes were proposed in this pull request?
reduce the denominator of SparkPi by 1
How was this patch tested?
integration tests