Skip to content

[SPARK-16111][SQL][DOC] Hide SparkOrcNewRecordReader in API docs#13914

Closed
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-16111
Closed

[SPARK-16111][SQL][DOC] Hide SparkOrcNewRecordReader in API docs#13914
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-16111

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jun 26, 2016

What changes were proposed in this pull request?

Currently, Spark Scala/Java API documents shows org.apache.hadoop.hive.ql.io.orc package at the top.

http://spark.apache.org/docs/2.0.0-preview/api/scala/index.html#org.apache.spark.package
http://spark.apache.org/docs/2.0.0-preview/api/java/index.html

This PR hides SparkOrcNewRecordReader from API docs.

How was this patch tested?

Manual. (build/sbt unidoc).

The following is the screenshot after this PR.

Scala API doc

Scala API doc

Java API doc

Java API doc

// Skip class names containing $ and some internal packages in Javadocs
unidocAllSources in (JavaUnidoc, unidoc) := {
ignoreUndocumentedPackages((unidocAllSources in (JavaUnidoc, unidoc)).value)
.map(_.filterNot(_.getCanonicalPath.contains("org/apache/hadoop/hive/ql/io/orc")))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can exclude the org.apache.hadoop.hive.ql.io.orc package from Javadoc in this way like the other exclusions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd exclude everything in org/apache/hadoop?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for review, @rxin . :)
Sure. I'll update it.

@dongjoon-hyun
Copy link
Member Author

Hi, @mengxr .
Could you review this PR?

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-16111][DOC] Hide SparkOrcNewRecordReader in API docs [SPARK-16111][SQL][DOC] Hide SparkOrcNewRecordReader in API docs Jun 26, 2016
@SparkQA
Copy link

SparkQA commented Jun 26, 2016

Test build #61267 has finished for PR 13914 at commit 63ab73a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Hi, @mengxr .
Could you review this PR when you have some time?

@SparkQA
Copy link

SparkQA commented Jun 28, 2016

Test build #61339 has finished for PR 13914 at commit 181e650.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jun 28, 2016

Merging in master/2.0.

asfgit pushed a commit that referenced this pull request Jun 28, 2016
## What changes were proposed in this pull request?

Currently, Spark Scala/Java API documents shows **org.apache.hadoop.hive.ql.io.orc** package at the top.

http://spark.apache.org/docs/2.0.0-preview/api/scala/index.html#org.apache.spark.package
http://spark.apache.org/docs/2.0.0-preview/api/java/index.html

This PR hides `SparkOrcNewRecordReader` from API docs.

## How was this patch tested?

Manual. (`build/sbt unidoc`).

The following is the screenshot after this PR.

**Scala API doc**

![Scala API doc](https://app.box.com/representation/file_version_75673952621/image_2048/1.png?shared_name=2mdqydygs8le6q9x00356898662zjwz6)

**Java API doc**

![Java API doc](https://app.box.com/representation/file_version_75673951725/image_2048/1.png?shared_name=iv23eeqy3avvkqz203v9ygfaqeyml85j)

Author: Dongjoon Hyun <dongjoon@apache.org>

Closes #13914 from dongjoon-hyun/SPARK-16111.

(cherry picked from commit 50fdd86)
Signed-off-by: Reynold Xin <rxin@databricks.com>
@asfgit asfgit closed this in 50fdd86 Jun 28, 2016
@dongjoon-hyun
Copy link
Member Author

Thank you for merging, @rxin .

@dongjoon-hyun dongjoon-hyun deleted the SPARK-16111 branch July 20, 2016 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants