[SPARK-16095][YARN] Yarn cluster mode should report correct state to SparkLauncher#13962
Closed
renozhang wants to merge 5 commits intoapache:masterfrom
Closed
[SPARK-16095][YARN] Yarn cluster mode should report correct state to SparkLauncher#13962renozhang wants to merge 5 commits intoapache:masterfrom
renozhang wants to merge 5 commits intoapache:masterfrom
Conversation
|
Test build #61438 has finished for PR 13962 at commit
|
| } | ||
| } | ||
|
|
||
| private object YarnClusterDriver extends Logging with Matchers { |
Contributor
Author
There was a problem hiding this comment.
In current YarnClusterDriver, it already has failures but not failed the test.
On line 340: calling sc.parallelize() after sc.stop() will fail app with error
ApplicationMaster: Final app status: FAILED, exitCode: 15, (reason: User class threw exception: java.lang.IllegalStateException: Cannot call methods on a stopped SparkContext.
|
Test build #61442 has finished for PR 13962 at commit
|
renozhang
changed the title
renozhang
changed the title
|
Test build #61474 has finished for PR 13962 at commit
|
Contributor
|
Looks good to me, CC @vanzin about |
| case YarnApplicationState.FINISHED => | ||
| reportLauncherState(SparkAppHandle.State.FINISHED) | ||
| report.getFinalApplicationStatus match { | ||
| case FinalApplicationStatus.FAILED => |
Contributor
There was a problem hiding this comment.
How about also handling KILLED? In case the app is killed via YARN UI / CLI.
|
Test build #61619 has finished for PR 13962 at commit
|
Contributor
Author
|
@vanzin I've updated code and comments. |
Contributor
|
LGTM. Merging to master / 2.0 (fix is simple enough and I'd rather have the whole 2.x line behave the same here). |
asfgit
pushed a commit
that referenced
this pull request
Jul 1, 2016
…SparkLauncher ## What changes were proposed in this pull request? Yarn cluster mode should return correct state for SparkLauncher ## How was this patch tested? unit test Author: peng.zhang <peng.zhang@xiaomi.com> Closes #13962 from renozhang/SPARK-16095-spark-launcher-wrong-state. (cherry picked from commit bad0f7d) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
zzcclp
added a commit
to zzcclp/spark
that referenced
this pull request
Jul 4, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Yarn cluster mode should return correct state for SparkLauncher
How was this patch tested?
unit test