Skip to content

[SPARK-16233][R][TEST] ORC test should be enabled only when HiveContext is available.#14019

Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-16233
Closed

[SPARK-16233][R][TEST] ORC test should be enabled only when HiveContext is available.#14019
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-16233

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jul 1, 2016

What changes were proposed in this pull request?

ORC test should be enabled only when HiveContext is available.

How was this patch tested?

Manual.

$ R/run-tests.sh
...
1. create DataFrame from RDD (@test_sparkSQL.R#200) - Hive is not build with SparkSQL, skipped

2. test HiveContext (@test_sparkSQL.R#1021) - Hive is not build with SparkSQL, skipped

3. read/write ORC files (@test_sparkSQL.R#1728) - Hive is not build with SparkSQL, skipped

4. enableHiveSupport on SparkSession (@test_sparkSQL.R#2448) - Hive is not build with SparkSQL, skipped

5. sparkJars tag in SparkContext (@test_Windows.R#21) - This test is only for Windows, skipped

DONE ===========================================================================
Tests passed.

@dongjoon-hyun
Copy link
Member Author

cc @shivaram

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-16223][R][TEST] ORC test should be enabled only when HiveContext is available. [SPARK-16233][R][TEST] ORC test should be enabled only when HiveContext is available. Jul 1, 2016
@SparkQA
Copy link

SparkQA commented Jul 1, 2016

Test build #61637 has finished for PR 14019 at commit 88141fe.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Jul 1, 2016

Thanks @dongjoon-hyun - I manually tested this as well and it works fine.

LGTM. Will merge after Jenkins passes

@dongjoon-hyun
Copy link
Member Author

Thank you, @shivaram .
It passed at Jenkins. As you see the log, Jenkins run the ORC tests.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jul 1, 2016

Is this included in new 2.0 RC if it exists?

@asfgit asfgit closed this in d17e5f2 Jul 1, 2016
asfgit pushed a commit that referenced this pull request Jul 1, 2016
…xt is available.

## What changes were proposed in this pull request?

ORC test should be enabled only when HiveContext is available.

## How was this patch tested?

Manual.
```
$ R/run-tests.sh
...
1. create DataFrame from RDD (test_sparkSQL.R#200) - Hive is not build with SparkSQL, skipped

2. test HiveContext (test_sparkSQL.R#1021) - Hive is not build with SparkSQL, skipped

3. read/write ORC files (test_sparkSQL.R#1728) - Hive is not build with SparkSQL, skipped

4. enableHiveSupport on SparkSession (test_sparkSQL.R#2448) - Hive is not build with SparkSQL, skipped

5. sparkJars tag in SparkContext (test_Windows.R#21) - This test is only for Windows, skipped

DONE ===========================================================================
Tests passed.
```

Author: Dongjoon Hyun <dongjoon@apache.org>

Closes #14019 from dongjoon-hyun/SPARK-16233.

(cherry picked from commit d17e5f2)
Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jul 1, 2016

Oh, thank you for merging. @shivaram .
This will be my fastest merging experience! (37 minutes)

@shivaram
Copy link
Contributor

shivaram commented Jul 1, 2016

@dongjoon-hyun I merged this into branch-2.0, so it should be present in the next RC.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-16233 branch July 20, 2016 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants