[MINOR][ML] update comment where is inconsistent with code in ml.regression.LinearRegression#14121
Closed
WeichenXu123 wants to merge 1 commit intoapache:masterfrom
Closed
[MINOR][ML] update comment where is inconsistent with code in ml.regression.LinearRegression#14121WeichenXu123 wants to merge 1 commit intoapache:masterfrom
WeichenXu123 wants to merge 1 commit intoapache:masterfrom
Conversation
|
Test build #62042 has finished for PR 14121 at commit
|
Member
|
OK |
Member
|
Merged to master/2.0 |
asfgit
pushed a commit
that referenced
this pull request
Jul 12, 2016
…ession.LinearRegression ## What changes were proposed in this pull request? In `train` method of `ml.regression.LinearRegression` when handling situation `std(label) == 0` the code replace `std(label)` with `mean(label)` but the relative comment is inconsistent, I update it. ## How was this patch tested? N/A Author: WeichenXu <WeichenXu123@outlook.com> Closes #14121 from WeichenXu123/update_lr_comment. (cherry picked from commit fc11c50) Signed-off-by: Sean Owen <sowen@cloudera.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
trainmethod ofml.regression.LinearRegressionwhen handling situationstd(label) == 0the code replace
std(label)withmean(label)but the relative comment is inconsistent, I update it.How was this patch tested?
N/A