[SPARK-16516][SQL] Support for pushing down filters for decimal and timestamp types in ORC#14172
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-16516][SQL] Support for pushing down filters for decimal and timestamp types in ORC#14172HyukjinKwon wants to merge 1 commit intoapache:masterfrom
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@liancheng I thought both were omitted in the original codes because |
|
Test build #62214 has finished for PR 14172 at commit
|
Member
Author
|
(cc @liancheng) |
Member
Author
|
Could you take a look please @yhuai and @liancheng ? |
Member
Author
|
Gentle ping @yhuai and @liancheng |
Contributor
|
LGTM, merging to master. Thanks! |
Member
Author
|
Thank you !!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It seems ORC supports all the types in (
PredicateLeaf.Type) which includes timestamp type and decimal type.In more details, the types listed in
SearchArgumentImpl.boxLiteral()can be used as a filter value.FYI, inital
casecaluse for supported types was introduced in 65d71bd and this was not changed overtime. At that time, Hive version was, 0.13 which supports only some types for filter-push down (See SearchArgumentImpl.java#L945-L965 at 0.13).However, the version was upgraded into 1.2.x and now it supports more types (See SearchArgumentImpl.java#L1068-L1093 at 1.2.0)
How was this patch tested?
Unit tests in
OrcFilterSuiteandOrcQuerySuite