[Minor][Build] Remove empty tags in parent pom.xml#14193
Closed
keypointt wants to merge 1 commit into
Closed
Conversation
|
Test build #62294 has finished for PR 14193 at commit
|
Member
|
No, I don't think any of these can be removed. Why would you assume an empty tag is meaningless? that's not true in any XML format. |
Contributor
Author
|
Hi Sean do you mind to explain a bit the meaning of the empty tags? Is it mean these empty paras can be set via command line like I googled around and didn't find a satisfying answer. Thanks a lot |
Member
|
The first one sets a property with an empty value. I think this is necessary to refer to it in the Maven build even if it doesn't have a default value. The rest -- refer to the plugin docs for that they mean. Empty tags are perfectly meaningful in XML. |
Contributor
Author
|
I get it now, thank you Sean for explaining this 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove empty tags in parent pom.xml
When I was working on another ticket and scanning code files randomly, I found these empty tags. I'm not sure if it is needed, or these empty tags are left on purpose.
If this is not a valid PR, please just let me know and I'll close it.
How was this patch tested?
Tested by re-building the project on my local machine.