[SPARK-16650] Improve documentation of spark.task.maxFailures#14287
[SPARK-16650] Improve documentation of spark.task.maxFailures#14287tgravescs wants to merge 2 commits intoapache:masterfrom
Conversation
docs/configuration.md
Outdated
| <td> | ||
| Number of individual task failures before giving up on the job. | ||
| Number of failures of any particular task before giving up on the job. The same | ||
| task has to fail this number of attempts, it isn't affected by the number of failures |
There was a problem hiding this comment.
for 2nd sentence maybe "Failures spread across different tasks will only cause the job to fail if one particular task has failed this number of times."?
There was a problem hiding this comment.
I can see the 2 sentence not being clear, but the second part of your suggestion about "if one particular task has failed" sounds a bit out of place to me, how about:
"The total number of failures spread across different tasks will not cause the job to fail, it has to be a particular task failing this number of attempts."
There was a problem hiding this comment.
"The total number of failures spread across different tasks will not cause the job to fail; a particular task has to fail this number of attempts."? (just to make it grammatically correct)
There was a problem hiding this comment.
(or your version is fine too if you don't think the grammar matters; either one is clear enough to the user I think)
There was a problem hiding this comment.
Sounds good. I am always open to grammar suggestions. I will update shortly.
|
I find the description "it isn't affected by the number of failures across different tasks." a little bit confusing. |
|
@rxin Other suggestions or should I just remove that? |
|
oops didn't see Kay's suggestion, that sounds better to me. |
|
Test build #62615 has finished for PR 14287 at commit
|
|
Test build #62622 has finished for PR 14287 at commit
|
|
lgtm |
Clarify documentation on spark.task.maxFailures No tests run as its documentation Author: Tom Graves <tgraves@yahoo-inc.com> Closes #14287 from tgravescs/SPARK-16650. (cherry picked from commit 6c56fff) Signed-off-by: Sean Owen <sowen@cloudera.com>
|
Merged to master/2.0 |
6 participants
Clarify documentation on spark.task.maxFailures
No tests run as its documentation