[SPARK-16701] Make parameters configurable in BlockManager#14338
Closed
lovexi wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-16701] Make parameters configurable in BlockManager#14338lovexi wants to merge 1 commit intoapache:masterfrom
lovexi wants to merge 1 commit intoapache:masterfrom
Conversation
lovexi
changed the title
|
Can one of the admins verify this patch? |
Contributor
|
I am opposed to this change because these are internal states that were never intended for the user to tweak. If there is a specific problem you're trying to fix then we should address that more generally instead. Please close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make parameters configurable in BlockManager class, such as max_attempts and sleep_time
How was this patch tested?
Using existing test cases