Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-16816] Modify java example which is also reflect in documentation exmaple #14436

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@phalodi
Copy link
Contributor

commented Aug 1, 2016

What changes were proposed in this pull request?

Modify java example which is also reflect in document.

How was this patch tested?

run test cases.

@phalodi phalodi changed the title modify java example which is also refelect in documentation exmaple [SPARK-16816] Modify java example which is also refelect in documentation exmaple Aug 1, 2016

@phalodi

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2016

@srowen @rxin Hey guyss i make changes as you suggested but yeah it not exactly what you suggested, i change in example which is also reflect in documentation, so please review it and give give your comments i will change them if you guyss think its not look good.

Changes which i made

screenshot from 2016-08-01 14-37-10

In currently spark 2.0 example for Json Dataset
spark2 0

In previous version example is as follows.
screenshot from 2016-08-01 15-00-57

So i make 2.0 example also same as previous version while user read this, he/she can also know how to create JavaSparkContext by spark session.

@phalodi phalodi changed the title [SPARK-16816] Modify java example which is also refelect in documentation exmaple [SPARK-16816] Modify java example which is also reflect in documentation exmaple Aug 1, 2016

@srowen

This comment has been minimized.

Copy link
Member

commented Aug 1, 2016

OK, it doesn't hurt. OK to merge if this seems to help your case.

@phalodi

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2016

@srowen Yeah i think its look better, complete the example like in earlier versions and also indirectly show how to works with java spark context while we have spark session.

@srowen

This comment has been minimized.

Copy link
Member

commented Aug 2, 2016

Jenkins test this please

@SparkQA

This comment has been minimized.

Copy link

commented Aug 2, 2016

Test build #63127 has finished for PR 14436 at commit 3461517.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
@srowen

This comment has been minimized.

Copy link
Member

commented Aug 2, 2016

Merged to master

@asfgit asfgit closed this in cbdff49 Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.