[SPARK-16870][docs]Summary:add "spark.sql.broadcastTimeout" into docs/sql-programming-gu…#14477
[SPARK-16870][docs]Summary:add "spark.sql.broadcastTimeout" into docs/sql-programming-gu…#14477biglobster wants to merge 2 commits intoapache:masterfrom
Conversation
…ide.md JIRA_ID:SPARK-16870 Description:default value for spark.sql.broadcastTimeout is 300s. and this property do not show in any docs of spark. so add "spark.sql.broadcastTimeout" into docs/sql-programming-guide.md to help people to how to fix this timeout error when it happenned Test:done
|
Many properties are not documented on purpose, because they're semi-private. What's the argument that this was intended to be public and set by callers? |
|
hi, @srowen |
|
Any objection to documenting it @liancheng ? |
docs/sql-programming-guide.md
Outdated
| </p> | ||
| </td> | ||
| </tr> | ||
| <tr> |
There was a problem hiding this comment.
PS this does not look like the right place for this option. This section covers Parquet. There's a later "other options" section covering broadcast join. Move it there.
There was a problem hiding this comment.
done. thx :) for you suggestion
JIRA_ID:SPARK-16870 Description:Move "spark.sql.broadcastTimeout" to broadcast join secsion Test:done
|
Jenkins test this please |
|
Test build #63322 has finished for PR 14477 at commit
|
…s/sql-programming-gu… ## What changes were proposed in this pull request? default value for spark.sql.broadcastTimeout is 300s. and this property do not show in any docs of spark. so add "spark.sql.broadcastTimeout" into docs/sql-programming-guide.md to help people to how to fix this timeout error when it happenned ## How was this patch tested? not need (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) …ide.md JIRA_ID:SPARK-16870 Description:default value for spark.sql.broadcastTimeout is 300s. and this property do not show in any docs of spark. so add "spark.sql.broadcastTimeout" into docs/sql-programming-guide.md to help people to how to fix this timeout error when it happenned Test:done Author: keliang <keliang@cmss.chinamobile.com> Closes #14477 from biglobster/keliang. (cherry picked from commit 1275f64) Signed-off-by: Sean Owen <sowen@cloudera.com>
|
Merged to master/2.0 |
|
@srowen Sorry for the late reply, this LGTM. |
What changes were proposed in this pull request?
default value for spark.sql.broadcastTimeout is 300s. and this property do not show in any docs of spark. so add "spark.sql.broadcastTimeout" into docs/sql-programming-guide.md to help people to how to fix this timeout error when it happenned
How was this patch tested?
not need
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
…ide.md
JIRA_ID:SPARK-16870
Description:default value for spark.sql.broadcastTimeout is 300s. and this property do not show in any docs of spark. so add "spark.sql.broadcastTimeout" into docs/sql-programming-guide.md to help people to how to fix this timeout error when it happenned
Test:done