Skip to content

[SPARK-12370] [Documentation] [Documentation should link to examples …#14596

Closed
jagadeesanas2 wants to merge 2 commits intoapache:masterfrom
ibmsoe:SPARK-12370
Closed

[SPARK-12370] [Documentation] [Documentation should link to examples …#14596
jagadeesanas2 wants to merge 2 commits intoapache:masterfrom
ibmsoe:SPARK-12370

Conversation

@jagadeesanas2
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

When documentation is built is should reference examples from the same build. There are times when the docs have links that point to files in the GitHub head which may not be valid on the current release. Changed that in URLs to make them point to the right tag in git using SPARK_VERSION_SHORT

…from its own release version] [Streaming programming guide]

…from its own release version] [Streaming programming guide]
@srowen
Copy link
Copy Markdown
Member

srowen commented Aug 11, 2016

This is reasonable, as it will connect released docs to examples matched to that release.
However there are many more occurrences of a link to "blob/master" in the docs; please address them all.

@srowen
Copy link
Copy Markdown
Member

srowen commented Aug 12, 2016

Great, that's all the occurrences, and I like that you added use of the SPARK_GITHUB_URL property.

@srowen
Copy link
Copy Markdown
Member

srowen commented Aug 12, 2016

Jenkins test this please

@srowen
Copy link
Copy Markdown
Member

srowen commented Aug 12, 2016

Jenkins add to whitelist

@SparkQA
Copy link
Copy Markdown

SparkQA commented Aug 12, 2016

Test build #63682 has finished for PR 14596 at commit 6808e0f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in e46cb78 Aug 13, 2016
asfgit pushed a commit that referenced this pull request Aug 13, 2016
## What changes were proposed in this pull request?

When documentation is built is should reference examples from the same build. There are times when the docs have links that point to files in the GitHub head which may not be valid on the current release. Changed that in URLs to make them point to the right tag in git using ```SPARK_VERSION_SHORT```

…from its own release version] [Streaming programming guide]

Author: Jagadeesan <as2@us.ibm.com>

Closes #14596 from jagadeesanas2/SPARK-12370.

(cherry picked from commit e46cb78)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@srowen
Copy link
Copy Markdown
Member

srowen commented Aug 13, 2016

Merged to master/2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants