Skip to content

[SPARK-17053][SQL] Support hive.exec.drop.ignorenonexistent#14636

Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-17053-HIVE-NON-EXISTENCE
Closed

[SPARK-17053][SQL] Support hive.exec.drop.ignorenonexistent#14636
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-17053-HIVE-NON-EXISTENCE

Conversation

@dongjoon-hyun
Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

If hive.exec.drop.ignorenonexistent is set true, DROP statement is assumed to have IF EXISTS clause.

Reported Error Scenario

scala> sql("set hive.exec.drop.ignorenonexistent=true")
res1: org.apache.spark.sql.DataFrame = [key: string, value: string]

scala> sql("drop table a")
org.apache.spark.sql.AnalysisException: Table to drop '`a`' does not exist;

Refer https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL .

How was this patch tested?

Pass the Jenkins test including a new test case.

@jaceklaskowski
Copy link
Copy Markdown
Contributor

The JIRA issue (https://issues.apache.org/jira/browse/SPARK-17053) is closed as Won't Fix. Should the PR be closed too?

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Nope, @jaceklaskowski . The discussion is not ended. The need of user is just supporting this option to support hive compatibility. I reopened the issue since he does not give any reason clearly.

@SparkQA
Copy link
Copy Markdown

SparkQA commented Aug 14, 2016

Test build #63752 has finished for PR 14636 at commit 0d25b25.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Hi, @rxin .
Could you review this PR about hive.exec.drop.ignorenonexistent?

@dongjoon-hyun
Copy link
Copy Markdown
Member Author

I'm close this issue since Spark does not want to support this option. The issue was finalized as WON'T FIX. See the Jira issue.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-17053-HIVE-NON-EXISTENCE branch January 7, 2019 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants