[WIP][SPARK-17082][CORE]Replace ByteBuffer with ChunkedByteBuffer#14662
Closed
witgo wants to merge 1 commit intoapache:masterfrom
Closed
[WIP][SPARK-17082][CORE]Replace ByteBuffer with ChunkedByteBuffer#14662witgo wants to merge 1 commit intoapache:masterfrom
witgo wants to merge 1 commit intoapache:masterfrom
Conversation
b6c1e3a to
b229441
Compare
|
Test build #63835 has finished for PR 14662 at commit
|
|
Test build #63837 has finished for PR 14662 at commit
|
This was referenced Aug 16, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The size of
ByteBufferscan not be greater than 2G, it should be replaced byChunkedByteBufferChunkedByteBuffer,ChunkedByteBufferInputStreamandChunkedByteBufferOutputStreamtocommon/network-common/src/main/java/org/apache/spark/network/buffer/public abstract ByteBuffer nioByteBuffer() throws IOException;=>public abstract ChunkedByteBuffer nioByteBuffer() throws IOException;add constructor
public FileSegmentManagedBuffer(long memoryMapBytes, boolean lazyFileDescriptor, File file, long offset, long length)Support Zero-copy in
nioByteBuffermethodadd constructor
public NioManagedBuffer(ChunkedByteBuffer buf)void onSuccess(ByteBuffer response)=>void onSuccess(ChunkedByteBuffer response)public long sendRpc(ByteBuffer message, final RpcResponseCallback callback)=>public long sendRpc(ChunkedByteBuffer message, final RpcResponseCallback callback)public ByteBuffer sendRpcSync(ByteBuffer message, long timeoutMs)=>ChunkedByteBuffer sendRpcSync(ChunkedByteBuffer message, long timeoutMs)public void send(ByteBuffer message)=>public void send(ChunkedByteBuffer message)public void receive(TransportClient client, ByteBuffer message, RpcResponseCallback callback)=>public void receive(TransportClient client, ChunkedByteBuffer message, RpcResponseCallback callback)public void receive(TransportClient client, ByteBuffer message)=>public void receive(TransportClient client, ChunkedByteBuffer message)public void receive(TransportClient client, ByteBuffer message, RpcResponseCallback callback)=>public void receive(TransportClient client, ChunkedByteBuffer message, RpcResponseCallback callback)public abstract void receive(TransportClient client, ByteBuffer message, RpcResponseCallback callback)=>public abstract void receive(TransportClient client, ChunkedByteBuffer message, RpcResponseCallback callback)public void receive(TransportClient client, ByteBuffer message)=>public void receive(TransportClient client, ChunkedByteBuffer message)public void onSuccess(ByteBuffer response)=>public void onSuccess(ChunkedByteBuffer response)BlockTransferMessage fromByteBuffer(ByteBuffer msg)=>public static BlockTransferMessage fromByteBuffer(ChunkedByteBuffer msg)def unBlockifyObject[T: ClassTag](blocks: Array[ByteBuffer], serializer: Serializer, compressionCodec: Option[CompressionCodec])=>def unBlockifyObject[T: ClassTag](blocks: Array[ChunkedByteBuffer], serializer: Serializer, compressionCodec: Option[CompressionCodec])def launchTask(context: ExecutorBackend, taskId: Long, attemptNumber: Int, taskName: String, serializedTask: ByteBuffer): Unit=>def launchTask(context: ExecutorBackend, taskId: Long, attemptNumber: Int, taskName: String, serializedTask: ChunkedByteBuffer): Unitdef statusUpdate(taskId: Long, state: TaskState, data: ByteBuffer): Unit=>def statusUpdate(taskId: Long, state: TaskState, data: ChunkedByteBuffer): Unitcase class OneWayOutboxMessage(content: ByteBuffer) extends OutboxMessage=>case class OneWayOutboxMessage(content: ChunkedByteBuffer) extends OutboxMessageserializeWithDependencies(task: Task[_], currentFiles: mutable.Map[String, Long], currentJars: mutable.Map[String, Long], serializer: SerializerInstance): ByteBuffer=>serializeWithDependencies(task: Task[_], currentFiles: mutable.Map[String, Long], currentJars: mutable.Map[String, Long], serializer: SerializerInstance): ChunkedByteBufferdeserializeWithDependencies(serializedTask: ByteBuffer): (HashMap[String, Long], HashMap[String, Long], Properties, ByteBuffer)=>deserializeWithDependencies(serializedTask: ChunkedByteBuffer): (HashMap[String, Long], HashMap[String, Long], Properties, ChunkedByteBuffer)private[spark] class TaskDescription(val taskId: Long, val attemptNumber: Int, val executorId: String, val name: String, val index: Int, val serializedTask: ChunkedByteBuffer)=>private[spark] class TaskDescription(val taskId: Long, val attemptNumber: Int, val executorId: String, val name: String, val index: Int, _serializedTask: ByteBuffer)private[spark] class DirectTaskResult[T](var valueBytes: ByteBuffer, var accumUpdates: Seq[AccumulatorV2[_, _]]) extends TaskResult[T]=>private[spark] class DirectTaskResult[T](var valueBytes: ChunkedByteBuffer, var accumUpdates: Seq[AccumulatorV2[_, _]]) extends TaskResult[T]def enqueueSuccessfulTask(taskSetManager: TaskSetManager, tid: Long, serializedData: ByteBuffer): Unit=>def enqueueSuccessfulTask(taskSetManager: TaskSetManager, tid: Long, serializedData: ChunkedByteBuffer): Unitdef enqueueFailedTask(taskSetManager: TaskSetManager, tid: Long, taskState: TaskState, serializedData: ByteBuffer)def enqueueFailedTask(taskSetManager: TaskSetManager, tid: Long, taskState: TaskState, serializedData: ChunkedByteBuffer)def statusUpdate(tid: Long, state: TaskState, serializedData: ByteBuffer)=>def statusUpdate(tid: Long, state: TaskState, serializedData: ChunkedByteBuffer)case class LaunchTask(data: SerializableBuffer) extends CoarseGrainedClusterMessage=>case class LaunchTask(data: ChunkedByteBuffer) extends CoarseGrainedClusterMessagecase class StatusUpdate(executorId: String, taskId: Long, state: TaskState, data: SerializableBuffer) extends CoarseGrainedClusterMessage=>case class StatusUpdate(executorId: String, taskId: Long, state: TaskState, data: ChunkedByteBuffer) extends CoarseGrainedClusterMessageprivate case class StatusUpdate(taskId: Long, state: TaskState, serializedData: ByteBuffer)=>private case class StatusUpdate(taskId: Long, state: TaskState, serializedData: ChunkedByteBuffer)def serialize[T: ClassTag](t: T): ByteBuffer=>def serialize[T: ClassTag](t: T): ChunkedByteBufferdef deserialize[T: ClassTag](bytes: ByteBuffer): T=>def deserialize[T: ClassTag](bytes: ChunkedByteBuffer): Tdef deserialize[T: ClassTag](bytes: ByteBuffer, loader: ClassLoader): T=>def deserialize[T: ClassTag](bytes: ChunkedByteBuffer, loader: ClassLoader): T`
How was this patch tested?
TODO: ....