Fixed a typo in the comments in RangePartitioner#1473
Fixed a typo in the comments in RangePartitioner#1473dorx wants to merge 2 commits intoapache:masterfrom
Conversation
Checked with Holden, the original author as per the log, and was told code is right comment is wrong.
|
QA tests have started for PR 1473. This patch merges cleanly. |
|
QA results for PR 1473: |
There was a problem hiding this comment.
Actually 1000 seems a pretty large number for doing linear scan. How about 64 or 128?
There was a problem hiding this comment.
That's why I noticed it in the first place. Would changing this number have unintended affects on people who're currently using the RangePartitioner?
There was a problem hiding this comment.
I don't think so. If anything, it should make it faster.
|
QA tests have started for PR 1473. This patch merges cleanly. |
|
QA results for PR 1473: |
|
It appears to me that the range partitioner is not correctly using the provided ordering in the case where it uses a binary search. |
|
I filed a JIRA: https://issues.apache.org/jira/browse/SPARK-2598 |
Checked with Holden, the original author as per the log, and was told
code is right comment is wrong.