-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-3162][MLlib][WIP] Add local tree training for decision tree regressors #14872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d by distributed Random Forest algorithm
|
ok to test |
|
Test build #64624 has finished for PR 14872 at commit
|
|
|
||
| // Update current model and node periphery. | ||
| // Note: This flatMap has side effects (on the model). | ||
| activeNodePeriphery = LocalDecisionTreeUtils.computeActiveNodePeriphery(activeNodePeriphery, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just get the children from computeBestSplits.
…ent. Some integration tests fail
|
Test build #64879 has finished for PR 14872 at commit
|
|
ok to test |
|
Test build #66067 has finished for PR 14872 at commit
|
|
Test build #66249 has finished for PR 14872 at commit
|
|
Can one of the admins verify this patch? |
|
Hi, is there any progress on this? |
|
Hi, I've stopped working on this PR - I can go ahead and close it. |
|
@smurching Sorry we haven't had time to continue with this. Please don't delete the branch; I'd like to pick it up eventually! |
|
No worries, apologies for being busy on my end -- I'll leave the branch up & try to contribute in other ways when I have the time! |
|
Hey, would definitely like to see this included in Spark. We are having issues with OOM errors training pretty small RFs. It could have something to do with the cross validation implementation as well, as it stores all of the models in memory at once. |
What changes were proposed in this pull request?
Based on Yggdrasil, added local training of decision tree regressors.
Some classes/objects largely correspond to Yggdrasil classes/objects.
Specifically:
How was this patch tested?
Added unit tests in (ml/tree/impl/LocalTreeTrainingSuite.scala) verifying that local & distributed training of a decision tree regressor produces the same tree.