[SPARK-17628][Streaming][Examples] change name "StreamingExamples" to be "StreamingExamplesUtils", more descriptive#15191
Closed
keypointt wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-17628][Streaming][Examples] change name "StreamingExamples" to be "StreamingExamplesUtils", more descriptive#15191keypointt wants to merge 1 commit intoapache:masterfrom
keypointt wants to merge 1 commit intoapache:masterfrom
Conversation
…ils, more descriptive
|
Test build #65748 has finished for PR 15191 at commit
|
Member
|
"Foobars" is a common name in Java / Scala for "static methods related to Foobar objects". I think the current name is fine. It's not really an API anyway, just a component of an example. |
Contributor
Author
|
oh I see...sorry...I'll close this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-17628
What changes were proposed in this pull request?
object StreamingExamplesis more of a utility object, and the name is too general. here changing it to beStreamingExamplesUtilsHow was this patch tested?
Tested manually on local laptop