[SPARK-17770] [CATALYST] making ObjectType public#15453
Closed
bdrillard wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-17770] [CATALYST] making ObjectType public#15453bdrillard wants to merge 1 commit intoapache:masterfrom
bdrillard wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
ok to test |
rxin
reviewed
Oct 12, 2016
Contributor
There was a problem hiding this comment.
I would put a InterfaceStability.Evolving to this.
Author
There was a problem hiding this comment.
Sure, I've updated the pull-request for the annotation.
|
Test build #66840 has finished for PR 15453 at commit
|
|
Test build #66926 has finished for PR 15453 at commit
|
|
Test build #66929 has finished for PR 15453 at commit
|
|
Test build #66930 has finished for PR 15453 at commit
|
Contributor
|
Thanks, merging to master! |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Nov 1, 2016
## What changes were proposed in this pull request? In order to facilitate the writing of additional Encoders, I proposed opening up the ObjectType SQL DataType. This DataType is used extensively in the JavaBean Encoder, but would also be useful in writing other custom encoders. As mentioned by marmbrus, it is understood that the Expressions API is subject to potential change. ## How was this patch tested? The change only affects the visibility of the ObjectType class, and the existing SQL test suite still runs without error. Author: ALeksander Eskilson <alek.eskilson@cerner.com> Closes apache#15453 from bdrillard/master.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? In order to facilitate the writing of additional Encoders, I proposed opening up the ObjectType SQL DataType. This DataType is used extensively in the JavaBean Encoder, but would also be useful in writing other custom encoders. As mentioned by marmbrus, it is understood that the Expressions API is subject to potential change. ## How was this patch tested? The change only affects the visibility of the ObjectType class, and the existing SQL test suite still runs without error. Author: ALeksander Eskilson <alek.eskilson@cerner.com> Closes apache#15453 from bdrillard/master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In order to facilitate the writing of additional Encoders, I proposed opening up the ObjectType SQL DataType. This DataType is used extensively in the JavaBean Encoder, but would also be useful in writing other custom encoders.
As mentioned by @marmbrus, it is understood that the Expressions API is subject to potential change.
How was this patch tested?
The change only affects the visibility of the ObjectType class, and the existing SQL test suite still runs without error.