Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Oct 14, 2016

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Please review https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark before opening a pull request.

@SparkQA
Copy link

SparkQA commented Oct 14, 2016

Test build #66925 has finished for PR 15474 at commit f3c8b7d.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 14, 2016

Test build #66943 has finished for PR 15474 at commit ca7295e.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Oct 14, 2016

Yeah, this is what I'm trying now, including putting it in the main flume artifact. No go. The assembly definitely has the class. I think it is somehow not sufficient to put this code in the app classpath with --jars. I mean, we could somehow try to merge the assembly jars into one for Pyspark tests. It is starting to get messy!

@zsxwing
Copy link
Member Author

zsxwing commented Oct 14, 2016

@srowen I ran the flume python tests locally and didnt find the same issue...

@srowen
Copy link
Member

srowen commented Oct 15, 2016

Did you clear your locally built artifacts first? maybe that's the difference. The Jenkins test here hits the same problem I was seeing.

@srowen
Copy link
Member

srowen commented Oct 15, 2016

PS I got this to work by making the pyspark tests specify the "userClassPathFirst" flags. I think that's actually reasonable to set. I will try this in my PR at #15436 and hope it works; if so you can close this I think.

@zsxwing zsxwing closed this Oct 16, 2016
@zsxwing zsxwing deleted the netty-test branch January 4, 2017 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants