[SPARK-18045][SQL][TESTS] Move `HiveDataFrameAnalyticsSuite` to package `sql` by jiangxb1987 · Pull Request #15582 · apache/spark

jiangxb1987 · 2016-10-21T09:08:50Z

What changes were proposed in this pull request?

The testsuite HiveDataFrameAnalyticsSuite has nothing to do with HIVE, we should move it to package sql.
The original test cases in that suite are splited into two existing testsuites: DataFrameAggregateSuite tests for the functions and ~~SQLQuerySuite~~SQLQueryTestSuite tests for the SQL statements.

How was this patch tested?

~~Modified SQLQuerySuite in package sql.~~
Add query file for SQLQueryTestSuite.

jiangxb1987 · 2016-10-21T09:14:17Z

sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameAnalyticsSuite.scala

-
-  test("rollup") {
-    checkAnswer(
-      testData.rollup($"a" + $"b", $"b").agg(sum($"a" - $"b")),


Rollup/Cube functions have been tested in DataFrameAggregateSuite.

SparkQA · 2016-10-21T11:23:32Z

Test build #67332 has finished for PR 15582 at commit 1c5277d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

rxin · 2016-10-21T18:07:52Z

Actually can we move these tests into a query file test?

In sql/core/src/test/resources/sql-tests

and check SQLQueryTestSuite

jiangxb1987 · 2016-10-23T01:58:15Z

@rxin I've moved the testcases added in this PR to an query file test, do we need to move other test cases for ROLLUP/CUBE/GROUPING-SETS too? Currently in SQLQuerySuite we have the following:

test("rollup")
test("grouping sets when aggregate functions containing groupBy columns") 
test("cube")
test("grouping sets")
test("grouping and grouping_id")
test("grouping and grouping_id in having")
test("grouping and grouping_id in sort")

rxin · 2016-10-23T03:06:55Z

It'd be great to move those as well!

SparkQA · 2016-10-23T03:53:45Z

Test build #67404 has finished for PR 15582 at commit 3066efc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-10-23T03:58:10Z

Test build #67403 has finished for PR 15582 at commit 5acbd6c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

rxin · 2016-10-23T07:10:26Z

I'm going to merge this first. Please submit a follow-up pr to move other ones.

rxin · 2016-10-23T07:18:03Z

(Actually I'm on an airplane and the internet is not good enough to merge patches).

rxin · 2016-10-23T07:18:29Z

cc @cloud-fan can you merge this?

hvanhovell · 2016-10-23T11:28:15Z

Merging to master. Thanks! Ping me for the follow-up.

…erySuite` into a query file test. ## What changes were proposed in this pull request? Currently we have several test cases for group analytics(ROLLUP/CUBE/GROUPING SETS) in `SQLQuerySuite`, should better move them into a query file test. The following test cases are moved to `group-analytics.sql`: ``` test("rollup") test("grouping sets when aggregate functions containing groupBy columns") test("cube") test("grouping sets") test("grouping and grouping_id") test("grouping and grouping_id in having") test("grouping and grouping_id in sort") ``` This is followup work of #15582 ## How was this patch tested? Modified query file `group-analytics.sql`, which will be tested by `SQLQueryTestSuite`. Author: jiangxingbo <jiangxb1987@gmail.com> Closes #15624 from jiangxb1987/group-analytics-test.

…ge `sql` ## What changes were proposed in this pull request? The testsuite `HiveDataFrameAnalyticsSuite` has nothing to do with HIVE, we should move it to package `sql`. The original test cases in that suite are splited into two existing testsuites: `DataFrameAggregateSuite` tests for the functions and ~~`SQLQuerySuite`~~`SQLQueryTestSuite` tests for the SQL statements. ## How was this patch tested? ~~Modified `SQLQuerySuite` in package `sql`.~~ Add query file for `SQLQueryTestSuite`. Author: jiangxingbo <jiangxb1987@gmail.com> Closes apache#15582 from jiangxb1987/group-analytics-test.

…erySuite` into a query file test. ## What changes were proposed in this pull request? Currently we have several test cases for group analytics(ROLLUP/CUBE/GROUPING SETS) in `SQLQuerySuite`, should better move them into a query file test. The following test cases are moved to `group-analytics.sql`: ``` test("rollup") test("grouping sets when aggregate functions containing groupBy columns") test("cube") test("grouping sets") test("grouping and grouping_id") test("grouping and grouping_id in having") test("grouping and grouping_id in sort") ``` This is followup work of apache#15582 ## How was this patch tested? Modified query file `group-analytics.sql`, which will be tested by `SQLQueryTestSuite`. Author: jiangxingbo <jiangxb1987@gmail.com> Closes apache#15624 from jiangxb1987/group-analytics-test.

…ge `sql` ## What changes were proposed in this pull request? The testsuite `HiveDataFrameAnalyticsSuite` has nothing to do with HIVE, we should move it to package `sql`. The original test cases in that suite are splited into two existing testsuites: `DataFrameAggregateSuite` tests for the functions and ~~`SQLQuerySuite`~~`SQLQueryTestSuite` tests for the SQL statements. ## How was this patch tested? ~~Modified `SQLQuerySuite` in package `sql`.~~ Add query file for `SQLQueryTestSuite`. Author: jiangxingbo <jiangxb1987@gmail.com> Closes apache#15582 from jiangxb1987/group-analytics-test.

…erySuite` into a query file test. ## What changes were proposed in this pull request? Currently we have several test cases for group analytics(ROLLUP/CUBE/GROUPING SETS) in `SQLQuerySuite`, should better move them into a query file test. The following test cases are moved to `group-analytics.sql`: ``` test("rollup") test("grouping sets when aggregate functions containing groupBy columns") test("cube") test("grouping sets") test("grouping and grouping_id") test("grouping and grouping_id in having") test("grouping and grouping_id in sort") ``` This is followup work of apache#15582 ## How was this patch tested? Modified query file `group-analytics.sql`, which will be tested by `SQLQueryTestSuite`. Author: jiangxingbo <jiangxb1987@gmail.com> Closes apache#15624 from jiangxb1987/group-analytics-test.

move HiveDataFrameAnalyticsSuite to sql.SQLQuerySuite.

1c5277d

jiangxb1987 commented Oct 21, 2016

View reviewed changes

jiangxb1987 added 2 commits October 23, 2016 09:43

move test cases to SQLQueryTestSuite

5acbd6c

remove test cases in SQLQuerySuite

3066efc

asfgit closed this in b158256 Oct 23, 2016

jiangxb1987 deleted the group-analytics-test branch October 24, 2016 04:48

jiangxb1987 mentioned this pull request Oct 25, 2016

[SPARK-18094][SQL][TESTS] Move group analytics test cases from SQLQuerySuite into a query file test. #15624

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SPARK-18045][SQL][TESTS] Move `HiveDataFrameAnalyticsSuite` to package `sql`#15582

[SPARK-18045][SQL][TESTS] Move `HiveDataFrameAnalyticsSuite` to package `sql`#15582
jiangxb1987 wants to merge 3 commits intoapache:masterfrom
jiangxb1987:group-analytics-test

jiangxb1987 commented Oct 21, 2016 •

edited

Loading

Uh oh!

jiangxb1987 Oct 21, 2016

Uh oh!

SparkQA commented Oct 21, 2016

Uh oh!

rxin commented Oct 21, 2016

Uh oh!

jiangxb1987 commented Oct 23, 2016

Uh oh!

rxin commented Oct 23, 2016

Uh oh!

SparkQA commented Oct 23, 2016

Uh oh!

SparkQA commented Oct 23, 2016

Uh oh!

rxin commented Oct 23, 2016

Uh oh!

rxin commented Oct 23, 2016

Uh oh!

rxin commented Oct 23, 2016

Uh oh!

hvanhovell commented Oct 23, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jiangxb1987 commented Oct 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

jiangxb1987 Oct 21, 2016

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Oct 21, 2016

Uh oh!

rxin commented Oct 21, 2016

Uh oh!

jiangxb1987 commented Oct 23, 2016

Uh oh!

rxin commented Oct 23, 2016

Uh oh!

SparkQA commented Oct 23, 2016

Uh oh!

SparkQA commented Oct 23, 2016

Uh oh!

rxin commented Oct 23, 2016

Uh oh!

rxin commented Oct 23, 2016

Uh oh!

rxin commented Oct 23, 2016

Uh oh!

hvanhovell commented Oct 23, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jiangxb1987 commented Oct 21, 2016 •

edited

Loading