[SPARK-18177][ML][PYSPARK] Add missing 'subsamplingRate' of pyspark GBTClassifier #15692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #67805 has finished for PR 15692 at commit
|
Member
|
You'll need to add the Param itself. (Search for |
zhengruifeng
force-pushed
the
gbt_subsamplingRate
branch
from
4b7c8fb to
0651bb6
Compare
Contributor
Author
|
@jkbradley I add this param for GBTClassifier and GBTRegressor. |
|
Test build #67862 has finished for PR 15692 at commit
|
jkbradley
reviewed
Nov 1, 2016
python/pyspark/ml/classification.py
Outdated
Member
There was a problem hiding this comment.
I'm sorry, I hadn't realized that this was already inherited from TreeEnsembleParams. Your original PR was correct.
zhengruifeng
force-pushed
the
gbt_subsamplingRate
branch
from
0651bb6 to
9e97eef
Compare
Contributor
Author
|
that's ok. I have delete the params. |
|
Test build #67948 has finished for PR 15692 at commit
|
Contributor
|
LGTM, merged into master and branch-2.1. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Nov 3, 2016
…BTClassifier ## What changes were proposed in this pull request? Add missing 'subsamplingRate' of pyspark GBTClassifier ## How was this patch tested? existing tests Author: Zheng RuiFeng <ruifengz@foxmail.com> Closes #15692 from zhengruifeng/gbt_subsamplingRate. (cherry picked from commit 9dc9f9a) Signed-off-by: Yanbo Liang <ybliang8@gmail.com>
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…BTClassifier ## What changes were proposed in this pull request? Add missing 'subsamplingRate' of pyspark GBTClassifier ## How was this patch tested? existing tests Author: Zheng RuiFeng <ruifengz@foxmail.com> Closes apache#15692 from zhengruifeng/gbt_subsamplingRate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add missing 'subsamplingRate' of pyspark GBTClassifier
How was this patch tested?
existing tests