[SPARK-18375][SPARK-18383][BUILD][CORE]Upgrade netty to 4.0.42.Final #15830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
witgo
changed the title
|
Test build #68408 has finished for PR 15830 at commit
|
witgo
changed the title
witgo
changed the title
srowen
reviewed
Nov 9, 2016
Member
There was a problem hiding this comment.
Seems OK. Do you need to check for a null message though, like above? In fact, the condition above for BindException could be e.getMessage != null || isBindCollision(e.getCause)
Contributor
Author
There was a problem hiding this comment.
From the netty code, the return of NativeIoException.getMessage is not null.
The only way to create a NativeIoException instance is to call Errors.newIOException
Member
There was a problem hiding this comment.
OK. It wouldn't hurt to be defensive rather than depend on this IMHO. If it changes then suddenly this becomes a mysterious NPE.
Contributor
Author
There was a problem hiding this comment.
OK, I will modify the code.
witgo
force-pushed
the
SPARK-18375_netty-4.0.42
branch
from
e73c1d9 to
c4546dc
Compare
|
Test build #68470 has finished for PR 15830 at commit
|
srowen
approved these changes
Nov 11, 2016
Member
|
Merged to master/2.1 |
asfgit
pushed a commit
that referenced
this pull request
Nov 12, 2016
## What changes were proposed in this pull request? One of the important changes for 4.0.42.Final is "Support any FileRegion implementation when using epoll transport netty/netty#5825". In 4.0.42.Final, `MessageWithHeader` can work properly when `spark.[shuffle|rpc].io.mode` is set to epoll ## How was this patch tested? Existing tests Author: Guoqiang Li <witgo@qq.com> Closes #15830 from witgo/SPARK-18375_netty-4.0.42. (cherry picked from commit bc41d99) Signed-off-by: Sean Owen <sowen@cloudera.com>
Contributor
Author
|
@srowen thank you |
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? One of the important changes for 4.0.42.Final is "Support any FileRegion implementation when using epoll transport netty/netty#5825". In 4.0.42.Final, `MessageWithHeader` can work properly when `spark.[shuffle|rpc].io.mode` is set to epoll ## How was this patch tested? Existing tests Author: Guoqiang Li <witgo@qq.com> Closes apache#15830 from witgo/SPARK-18375_netty-4.0.42.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
One of the important changes for 4.0.42.Final is "Support any FileRegion implementation when using epoll transport netty/netty#5825".
In 4.0.42.Final,
MessageWithHeadercan work properly whenspark.[shuffle|rpc].io.modeis set to epollHow was this patch tested?
Existing tests