[SPARK][EXAMPLE] Added missing semicolon in quick-start-guide example#16081
Closed
manishatGit wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK][EXAMPLE] Added missing semicolon in quick-start-guide example#16081manishatGit wants to merge 1 commit intoapache:masterfrom
manishatGit wants to merge 1 commit intoapache:masterfrom
Conversation
srowen
approved these changes
Nov 30, 2016
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Yeah, it's trivial, but it is needed to make the example compile. Could you look over other examples nearby in Java and see if you spot any other similar problems?
Member
|
Jenkins test this please |
|
Test build #69407 has finished for PR 16081 at commit
|
Author
|
@srowen I scanned this page and Spark programming guide for other Java code examples, apart from Self-Contained Application on Quick-start-guide page, other code examples have no such problems. |
Contributor
|
Ok, merging into master 2.1 |
asfgit
pushed a commit
that referenced
this pull request
Nov 30, 2016
## What changes were proposed in this pull request? Added missing semicolon in quick-start-guide java example code which wasn't compiling before. ## How was this patch tested? Locally by running and generating site for docs. You can see the last line contains ";" in the below snapshot.  Author: manishAtGit <manish@knoldus.com> Closes #16081 from manishatGit/fixed-quick-start-guide. (cherry picked from commit bc95ea0) Signed-off-by: Andrew Or <andrewor14@gmail.com>
asfgit
pushed a commit
that referenced
this pull request
Nov 30, 2016
## What changes were proposed in this pull request? Added missing semicolon in quick-start-guide java example code which wasn't compiling before. ## How was this patch tested? Locally by running and generating site for docs. You can see the last line contains ";" in the below snapshot.  Author: manishAtGit <manish@knoldus.com> Closes #16081 from manishatGit/fixed-quick-start-guide.
Contributor
|
and 2.0 |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 2, 2016
## What changes were proposed in this pull request? Added missing semicolon in quick-start-guide java example code which wasn't compiling before. ## How was this patch tested? Locally by running and generating site for docs. You can see the last line contains ";" in the below snapshot.  Author: manishAtGit <manish@knoldus.com> Closes apache#16081 from manishatGit/fixed-quick-start-guide.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? Added missing semicolon in quick-start-guide java example code which wasn't compiling before. ## How was this patch tested? Locally by running and generating site for docs. You can see the last line contains ";" in the below snapshot.  Author: manishAtGit <manish@knoldus.com> Closes apache#16081 from manishatGit/fixed-quick-start-guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added missing semicolon in quick-start-guide java example code which wasn't compiling before.
How was this patch tested?
Locally by running and generating site for docs. You can see the last line contains ";" in the below snapshot.
