[SQL] Minor readability improvement for partition handling code#16378
Closed
rxin wants to merge 2 commits intoapache:masterfrom
Closed
[SQL] Minor readability improvement for partition handling code#16378rxin wants to merge 2 commits intoapache:masterfrom
rxin wants to merge 2 commits intoapache:masterfrom
Conversation
rxin
commented
Dec 21, 2016
| /** | ||
| * Use [[FileStatusCache.getOrCreate()]] to construct a globally shared file status cache. | ||
| */ | ||
| object FileStatusCache { |
Contributor
Author
There was a problem hiding this comment.
I moved this from the middle of the file to the front since it is the logical entry point.
Contributor
Author
|
cc @ericl |
|
Test build #70497 has finished for PR 16378 at commit
|
Contributor
Author
|
cc @cloud-fan too |
Contributor
|
LGTM, merging to master |
Contributor
Author
|
I've also cherry picked this into branch-2.1. |
asfgit
pushed a commit
that referenced
this pull request
Dec 22, 2016
This patch includes minor changes to improve readability for partition handling code. I'm in the middle of implementing some new feature and found some naming / implicit type inference not as intuitive. This patch should have no semantic change and the changes should be covered by existing test cases. Author: Reynold Xin <rxin@databricks.com> Closes #16378 from rxin/minor-fix. (cherry picked from commit 7c5b7b3) Signed-off-by: Reynold Xin <rxin@databricks.com>
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Dec 24, 2016
## What changes were proposed in this pull request? This patch includes minor changes to improve readability for partition handling code. I'm in the middle of implementing some new feature and found some naming / implicit type inference not as intuitive. ## How was this patch tested? This patch should have no semantic change and the changes should be covered by existing test cases. Author: Reynold Xin <rxin@databricks.com> Closes apache#16378 from rxin/minor-fix.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? This patch includes minor changes to improve readability for partition handling code. I'm in the middle of implementing some new feature and found some naming / implicit type inference not as intuitive. ## How was this patch tested? This patch should have no semantic change and the changes should be covered by existing test cases. Author: Reynold Xin <rxin@databricks.com> Closes apache#16378 from rxin/minor-fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch includes minor changes to improve readability for partition handling code. I'm in the middle of implementing some new feature and found some naming / implicit type inference not as intuitive.
How was this patch tested?
This patch should have no semantic change and the changes should be covered by existing test cases.