Skip to content

Conversation

@hvanhovell
Copy link
Contributor

@hvanhovell hvanhovell commented Feb 23, 2017

What changes were proposed in this pull request?

This is a backport of the two following commits: 78eae7e & de8a03e

This PR adds support for ORC tables with (nested) char/varchar fields.

How was this patch tested?

Added a regression test to OrcSourceSuite.

## What changes were proposed in this pull request?
This PR is a small follow-up on apache#16804. This PR also adds support for nested char/varchar fields in orc.

## How was this patch tested?
I have added a regression test to the OrcSourceSuite.

Author: Herman van Hovell <hvanhovell@databricks.com>

Closes apache#17030 from hvanhovell/SPARK-19459-follow-up.

# Conflicts:
#	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
#	sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala
## What changes were proposed in this pull request?
This PR is a small follow-up on apache#16804. This PR also adds support for nested char/varchar fields in orc.

## How was this patch tested?
I have added a regression test to the OrcSourceSuite.

Author: Herman van Hovell <hvanhovell@databricks.com>

Closes apache#17030 from hvanhovell/SPARK-19459-follow-up.

# Conflicts:
#	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
#	sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala
Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending Jenkin

@SparkQA
Copy link

SparkQA commented Feb 23, 2017

Test build #73358 has finished for PR 17041 at commit ba71b45.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

Thanks! Merging to 2.1.

asfgit pushed a commit that referenced this pull request Feb 23, 2017
… in ORC

## What changes were proposed in this pull request?
This is a backport of the two following commits: 78eae7e & de8a03e

This PR adds support for ORC tables with (nested) char/varchar fields.

## How was this patch tested?
Added a regression test to `OrcSourceSuite`.

Author: Herman van Hovell <hvanhovell@databricks.com>

Closes #17041 from hvanhovell/SPARK-19459-branch-2.1.
@gatorsmile
Copy link
Member

Cloud you close the PR now?

@hvanhovell
Copy link
Contributor Author

Thanks!

@hvanhovell hvanhovell closed this Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants