Skip to content

[SPARK-19756][SQL] drop the table cache after inserting into a data source table #17089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cloud-fan wants to merge 1 commit into from
Closed

[SPARK-19756][SQL] drop the table cache after inserting into a data source table #17089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .../scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,9 @@ case class InsertIntoHadoopFsRelationCommand(
options = options)

fileIndex.foreach(_.refresh())
catalogTable.foreach { table =>
sparkSession.sharedState.cacheManager.uncacheQuery(sparkSession.table(table.identifier))
Copy link
Copy Markdown
Contributor

@windpiger windpiger Feb 28, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncache it or refresh it use refreshByPath?
In this PR

Copy link
Copy Markdown
Member

@gatorsmile gatorsmile Feb 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can make the behavior consistent with what we did for insertion of Hive serve tables

Copy link
Copy Markdown
Contributor

@windpiger windpiger Feb 28, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is recached? maybe we can use invalidateCachedPath https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala#L154

}
} else {
logInfo("Skipping insertion into a relation that already exists.")
}
Expand Down
11 changes: 11 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,4 +634,15 @@ class CachedTableSuite extends QueryTest with SQLTestUtils with SharedSQLContext
assert(getNumInMemoryRelations(cachedPlan2) == 4)
}
}

test("SPARK-19756: drop the table cache after inserting into a data source table") {
withTable("t") {
Seq(1 -> "a").toDF("i", "j").write.saveAsTable("t")
spark.catalog.cacheTable("t")
checkAnswer(spark.table("t"), Row(1, "a"))

sql("INSERT INTO t SELECT 2, 'b'")
checkAnswer(spark.table("t"), Row(1, "a") :: Row(2, "b") :: Nil)
}
}
}