Skip to content

Conversation

@zhzhan
Copy link
Contributor

@zhzhan zhzhan commented Mar 3, 2017

What changes were proposed in this pull request?

Change the orderable condition.

How was this patch tested?

Relies on existing test.

Please review http://spark.apache.org/contributing.html before opening a pull request.

@zhzhan zhzhan changed the title [SPARK-19815][SQL] Not order able should be applied to right key instead of left key [SPARK-19815][SQL] Not orderable should be applied to right key instead of left key Mar 3, 2017
@SparkQA
Copy link

SparkQA commented Mar 4, 2017

Test build #73873 has finished for PR 17155 at commit 91a6165.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

@zhzhan
Copy link
Contributor Author

zhzhan commented Mar 4, 2017

@gatorsmile Thanks for reviewing this. I am thinking the logic again. On the surface, the logic may be correct. Since in the join, the left and right key should be the same type. Will close the PR.

@zhzhan zhzhan closed this Mar 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants