[SPARK-20088] Do not create new SparkContext in SparkR createSparkContext #17423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #75193 has finished for PR 17423 at commit
|
Member
|
(I just happened to see this does not trigger the build with AppVeyor. Let me leave a build that I triggered with this by my account). |
Member
|
this is already checked on the R side and we should never call |
Contributor
|
@felixcheung |
Member
|
sure, that's just the context around it |
Contributor
|
got it. Thanks :) |
Contributor
|
LGTM. Merged into master. The failed tests are irrelevant to this PR, fixed in a2ce0a2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Instead of creating new
JavaSparkContextwe useSparkContext.getOrCreate.How was this patch tested?
Existing tests