[SPARK-17137][ML][WIP] Compress logistic regression coefficients #17426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #75205 has finished for PR 17426 at commit
|
dbtsai
approved these changes
Mar 25, 2017
Member
dbtsai
left a comment
dbtsai
left a comment
There was a problem hiding this comment.
LGTM. Merged into master. Thanks.
| @@ -617,26 +612,13 @@ class LogisticRegression @Since("1.2.0") ( | |||
| denseCoefficientMatrix.update(_ - coefficientMean) | |||
| } | |||
|
|
|||
Member
There was a problem hiding this comment.
BTW, we could compress the coefficients from driver to executors to save communication cost. Can do in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use the new
compressedmethod on matrices to store the logistic regression coefficients as sparse or dense - whichever is requires less memory.Marked as WIP so we can add some performance test results. Basically, we should see if prediction is slower because of using a sparse matrix over a dense one. This can happen since sparse matrices do not use native BLAS operations when computing the margins.
How was this patch tested?
Unit tests added.