[MINOR][R] Reorder Collate fields in DESCRIPTION file#17528
Closed
HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Closed
[MINOR][R] Reorder Collate fields in DESCRIPTION file#17528HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Collate fields in DESCRIPTION file#17528HyukjinKwon wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@felixcheung, maybe it is not worth being as a separate PR. I am fine if you add this in any of your PR that is going to be merged soon. I just opened this as I just found while playing with SparkR locally. |
|
Test build #75509 has finished for PR 17528 at commit
|
Member
|
that's fine I'm at a lost at how it decides the order? The first part is completely unsorted, right? |
felixcheung
approved these changes
Apr 4, 2017
Member
|
merged to master. |
Member
Author
|
I just found some references about the order. It seems there was a question about it - http://stackoverflow.com/questions/18544006/how-do-i-indicate-collate-order-in-roxygen2 and https://cran.r-project.org/web/packages/roxygen2/roxygen2.pdf I didn't run a lot of tests as fortunately It sounds deterministic at least. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It seems cran check scripts corrects
R/pkg/DESCRIPTIONand follows the order inCollatefields.This PR proposes to fix
catalog.R's order so that running this script does not show up a small diff in this file every time.How was this patch tested?
Manually via
./R/check-cran.sh.