[SPARK-20005][WEB UI]fix 'There is no "Newline" in UI in describtion'. #17563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 31, 2017 21:57
…remove redundant description.
|
Can one of the admins verify this patch? |
srowen
requested changes
Apr 7, 2017
|
|
||
| override def tableCssClass: String = | ||
| "table table-bordered table-condensed table-striped " + | ||
| "table table-bordered table-condensed table-striped sortable " + |
Member
There was a problem hiding this comment.
It doesn't sound like this just makes it wrap. I'm not sure what the implications are of this?
| <tr> | ||
| <td><code>/applications/[app-id]/stages</code></td> | ||
| <td>A list of all stages for a given application.</td> | ||
| <br><code>?status=[active|complete|pending|failed]</code> list only stages in the state. |
Author
There was a problem hiding this comment.
sorry,this is Unrelated. I merge code is error about docs/monitoring.md.
guoxiaolongzte
changed the title
Author
|
@srowen sorry,this is Unrelated. I merge code is error about docs/monitoring.md. |
Member
|
Ping @guoxiaolongzte to fix or close but i'm not yet clear this does only what you intend. |
Author
|
Does the PR nobody deal with it?@srowen |
Member
|
@guoxiaolongzte I'm not sure what you're asking. It is up to you to fix this pull request, or else close it if you're not going to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Before I fix this issue, if the describtion is too long, the content is still displayed on a line, causing the cell to be stretched indefinitely. The UI page is very ugly.
Add a css class, if the overdone is too long, I will automatically intercept the string, with '...' to replace, if the user wants to see more detailed in the word, you can double click to describtion, then more lines show the detail of describtion, then the UI page comparison Regular.
Please refer to the attachment of issue 'SPARK-20005',before_fix_jobs.png, before_fix_stages.png and after_fix_jobs.png, after_fix_stages.png.
issue url:https://issues.apache.org/jira/browse/SPARK-20005.
How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.