Skip to content

[SPARK-1986][GraphX]move lib.Analytics to org.apache.spark.examples #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
larryxiao wants to merge 1 commit into from
Closed

[SPARK-1986][GraphX]move lib.Analytics to org.apache.spark.examples #1766

larryxiao wants to merge 1 commit into from

Conversation

@larryxiao
Copy link
Contributor

@larryxiao larryxiao commented Aug 4, 2014

to support ~/spark/bin/run-example GraphXAnalytics triangles
/soc-LiveJournal1.txt --numEPart=256

@AmplabJenkins
Copy link

AmplabJenkins commented Aug 4, 2014

Can one of the admins verify this patch?

@ankurdave
Copy link
Contributor

ankurdave commented Aug 4, 2014

Thanks for taking this on! ok to test

ankurdave
ankurdave reviewed Aug 4, 2014
View reviewed changes
examples/src/main/scala/org/apache/spark/examples/graphx/Analytics.scala Outdated
Copy link
Contributor

@ankurdave ankurdave Aug 4, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be org.apache.spark.examples.graphx

@SparkQA
Copy link

SparkQA commented Aug 4, 2014

QA tests have started for PR 1766. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17861/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 4, 2014

QA results for PR 1766:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17861/consoleFull

@larryxiao
Copy link
Contributor Author

larryxiao commented Aug 5, 2014

Thanks Ankur, let me fix it.
Also didn't notice Analytics is referenced by LiveJournalPageRank.

So I'll make a new pull request?

@ankurdave
Copy link
Contributor

ankurdave commented Aug 5, 2014

You can just update this pull request by pushing to your 1986 branch.

@larryxiao
[SPARK-1986][GraphX]move lib.Analytics to org.apache.spark.examples
bb77cd9 
to support ~/spark/bin/run-example GraphXAnalytics triangles
/soc-LiveJournal1.txt --numEPart=256

move to graphx package, correct reference in LiveJournalPageRank

can now run:
~/spark/bin/run-example graphx.Analytics triangles soc-LiveJournal1.txt
--numEPart=256
~/spark/bin/run-example graphx.LiveJournalPageRank
soc-LiveJournal1.txt --numEPart=256
@larryxiao
Copy link
Contributor Author

larryxiao commented Aug 5, 2014

Thanks Ankur
it's ready now

@SparkQA
Copy link

SparkQA commented Aug 5, 2014

QA tests have started for PR 1766. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17914/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 5, 2014

QA results for PR 1766:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17914/consoleFull

@larryxiao
Copy link
Contributor Author

larryxiao commented Aug 11, 2014

@ankurdave
Can you check again?
Thank you!

@asfgit asfgit closed this in 7c92b49 Sep 3, 2014
@ankurdave
Copy link
Contributor

ankurdave commented Sep 3, 2014

Thanks! Merged this into master.

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@larryxiao @conviva-zz
[SPARK-1986][GraphX]move lib.Analytics to org.apache.spark.examples
8e5c3b1 
to support ~/spark/bin/run-example GraphXAnalytics triangles
/soc-LiveJournal1.txt --numEPart=256

Author: Larry Xiao <xiaodi@sjtu.edu.cn>

Closes apache#1766 from larryxiao/1986 and squashes the following commits:

bb77cd9 [Larry Xiao] [SPARK-1986][GraphX]move lib.Analytics to org.apache.spark.examples
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
@sunchao
rdar://110070310 Bump Hive version to 2.3.9.6-apple (apache#1766)
1c36824 
Change log: https://github.pie.apple.com/IPR/apache-hive/compare/277d151c1c9c8977b54b17f1e5c0ecbe63bfd2d4...1aaf9e1c038bfd52c6c8a26be26cd8aade528a0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@larryxiao @AmplabJenkins @ankurdave @SparkQA