[SPARKR][DOCS][MINOR] Use consistent names in rollup and cube examples #17988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #76950 has finished for PR 17988 at commit
|
felixcheung
approved these changes
May 16, 2017
Member
felixcheung
left a comment
felixcheung
left a comment
There was a problem hiding this comment.
LGTM - please update PR title to have [SPARKR]
anything else in the examples you can fix/improve?
zero323
changed the title
Member
Author
|
Let me take another look :) |
bdwyer2
approved these changes
May 16, 2017
Member
Author
|
I took another look and I think it is OK how it is. If we were to actually run the examples we'll need a bigger clean-up but it is a different topic. |
Member
|
merged to master |
lycplus
pushed a commit
to lycplus/spark
that referenced
this pull request
May 24, 2017
## What changes were proposed in this pull request? Rename `carsDF` to `df` in SparkR `rollup` and `cube` examples. ## How was this patch tested? Manual tests. Author: zero323 <zero323@users.noreply.github.com> Closes apache#17988 from zero323/cube-docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rename
carsDFtodfin SparkRrollupandcubeexamples.How was this patch tested?
Manual tests.