[WIP][SPARK-20824][SQL] Generate code to get value from table cache with wider column in ColumnarBatch#18194
Closed
kiszk wants to merge 4 commits intoapache:masterfrom
Closed
[WIP][SPARK-20824][SQL] Generate code to get value from table cache with wider column in ColumnarBatch#18194kiszk wants to merge 4 commits intoapache:masterfrom
kiszk wants to merge 4 commits intoapache:masterfrom
Conversation
|
Test build #77715 has finished for PR 18194 at commit
|
Member
Author
|
Jenkins, retest this please |
|
Test build #77716 has finished for PR 18194 at commit
|
Member
|
@kiszk Could we close this PR? and you can re-submit it later. |
Member
Author
|
Sure, it will not be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR waits for merging #18066
This PR adds compensation code for disabling the whole-stage codegen due to large number of columns.
When the whole-stage codegen is disabled, an iterator gets data from a row. Since the data is stored in columnar sotrage
CachedBatch, the iterator is generated to copy data from the columnar storage to a row.This PR supports only interger and double types. Another PR will support other data types.
How was this patch tested?
Added test suites into
InMemoryColumnarQuerySuite