[SPARK-21358][Examples] Argument of repartitionandsortwithinpartitions at pyspark#18586
[SPARK-21358][Examples] Argument of repartitionandsortwithinpartitions at pyspark#18586chie8842 wants to merge 3 commits intoapache:masterfrom
Conversation
|
The extra test is nice too, yeah. By the way if you change the title to include |
…asc and added test_repartitionAndSortWithinPartitions_desc
|
Test build #3840 has finished for PR 18586 at commit
|
|
Your new test looks reasonable, though it failed, because I believe the sorting is only by key. It wouldn't necessarily cause them to be ordered by the second value in the tuple. The example is a little bit misleading because it sort of looks like it is sorting by value too. But, I think you could just adjust the test to expect the actual order as it happens here. The output was sorted by key, correctly. |
|
@srowen Thank you for pointing out about test fail. I fixed it. |
|
Test build #3841 has finished for PR 18586 at commit
|
|
Merging in master. Thanks. |
What changes were proposed in this pull request?
At example of repartitionAndSortWithinPartitions at rdd.py, third argument should be True or False.
I proposed fix of example code.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.