-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-16872][ML] Add Gaussian NB #18589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #79464 has finished for PR 18589 at commit
|
|
Test build #79489 has finished for PR 18589 at commit
|
|
Test build #79490 has finished for PR 18589 at commit
|
|
Test build #79491 has finished for PR 18589 at commit
|
|
Test build #79499 has finished for PR 18589 at commit
|
|
Test build #79507 has finished for PR 18589 at commit
|
|
Jenkins, retest this please |
|
Test build #79509 has finished for PR 18589 at commit
|
|
Jenkins, retest this please |
|
Test build #79516 has finished for PR 18589 at commit
|
|
The previous PR had some discussion around whether this should be a new estimator or not. It's not clear why you've opened a new PR? It's also not clear that decision was actually made. I think the consensus was more towards making GaussianNB a distinct estimator / model combination. cc @sethah |
ff1c6f9 to
e71a069
Compare
|
Test build #80672 has finished for PR 18589 at commit
|
|
Test build #80677 has finished for PR 18589 at commit
|
What changes were proposed in this pull request?
Add Gaussian NB
How was this patch tested?
existing tests and added tests