Skip to content

[MINOR][ML] Reorg RFormula params.#18681

Closed
yanboliang wants to merge 1 commit intoapache:masterfrom
yanboliang:rformula-reorg
Closed

[MINOR][ML] Reorg RFormula params.#18681
yanboliang wants to merge 1 commit intoapache:masterfrom
yanboliang:rformula-reorg

Conversation

@yanboliang
Copy link
Contributor

@yanboliang yanboliang commented Jul 19, 2017

What changes were proposed in this pull request?

There are mainly two reasons for this reorg:

  • Some params are placed in RFormulaBase, while others are placed in RFormula, this is disordered.
  • RFormulaModel should have params handleInvalid, formula and forceIndexLabel, that users can get invalid values handling policy, formula or whether to force index label if they only have a RFormulaModel. So we need move these params to RFormulaBase which is also inherited by RFormulaModel.
  • RFormulaModel should support set different handleInvalid when cross validation.

How was this patch tested?

Existing tests.

@SparkQA
Copy link

SparkQA commented Jul 19, 2017

Test build #79755 has finished for PR 18681 at commit 673d2df.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yanboliang
Copy link
Contributor Author

cc @felixcheung

@yanboliang
Copy link
Contributor Author

Merged into master. Thanks for reviewing.

@asfgit asfgit closed this in 5d1850d Jul 20, 2017
@yanboliang yanboliang deleted the rformula-reorg branch July 20, 2017 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants