Skip to content

[SPARK-7146][ML] Expose the common params as a DeveloperAPI for other ML developers#18699

Closed
holdenk wants to merge 3 commits intoapache:masterfrom
holdenk:SPARK-7146-ml-shared-params-developer-api
Closed

[SPARK-7146][ML] Expose the common params as a DeveloperAPI for other ML developers#18699
holdenk wants to merge 3 commits intoapache:masterfrom
holdenk:SPARK-7146-ml-shared-params-developer-api

Conversation

@holdenk
Copy link
Contributor

@holdenk holdenk commented Jul 21, 2017

What changes were proposed in this pull request?

Expose the common params from Spark ML as a Developer API.

How was this patch tested?

Existing tests.

@SparkQA
Copy link

SparkQA commented Jul 21, 2017

Test build #79825 has finished for PR 18699 at commit 1ee22f0.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • |trait Has$Name extends Params
  • trait HasRegParam extends Params
  • trait HasMaxIter extends Params
  • trait HasFeaturesCol extends Params
  • trait HasLabelCol extends Params
  • trait HasPredictionCol extends Params
  • trait HasRawPredictionCol extends Params
  • trait HasProbabilityCol extends Params
  • trait HasVarianceCol extends Params
  • trait HasThreshold extends Params
  • trait HasThresholds extends Params
  • trait HasInputCol extends Params
  • trait HasInputCols extends Params
  • trait HasOutputCol extends Params
  • trait HasCheckpointInterval extends Params
  • trait HasFitIntercept extends Params
  • trait HasHandleInvalid extends Params
  • trait HasStandardization extends Params
  • trait HasSeed extends Params
  • trait HasElasticNetParam extends Params
  • trait HasTol extends Params
  • trait HasStepSize extends Params
  • trait HasWeightCol extends Params
  • trait HasSolver extends Params
  • trait HasAggregationDepth extends Params

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be "This trait"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

@holdenk
Copy link
Contributor Author

holdenk commented Jul 25, 2017

cc @jkbradley

@holdenk holdenk force-pushed the SPARK-7146-ml-shared-params-developer-api branch from 1ee22f0 to a53c460 Compare October 25, 2017 11:50
@holdenk
Copy link
Contributor Author

holdenk commented Oct 25, 2017

And updated after being called out in a talk and Spark Summit :p

@SparkQA
Copy link

SparkQA commented Oct 25, 2017

Test build #83042 has finished for PR 18699 at commit a53c460.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@holdenk holdenk changed the title [SPARK-7146][ML][WIP] Expose the common params as a DeveloperAPI for other ML developers [SPARK-7146][ML] Expose the common params as a DeveloperAPI for other ML developers Oct 25, 2017
@holdenk
Copy link
Contributor Author

holdenk commented Nov 6, 2017

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Nov 6, 2017

Test build #83470 has finished for PR 18699 at commit c6a7ddf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@holdenk
Copy link
Contributor Author

holdenk commented Nov 6, 2017

Merged into master

@asfgit asfgit closed this in 4bacddb Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants