[SPARK-21606][SQL]HiveThriftServer2 catches OOMs on request threads #18812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
cc @liufengdb Is this PR in the right track? |
liufengdb
reviewed
Dec 17, 2017
| import java.util.List; | ||
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.SynchronousQueue; | ||
| import java.util.concurrent.TimeUnit; |
liufengdb
reviewed
Dec 17, 2017
| import org.apache.hive.service.cli.thrift.ThriftCLIService; | ||
| import org.apache.hive.service.cli.thrift.ThriftHttpCLIService; | ||
|
|
||
| import java.util.Properties; |
|
I actually did not get the motivation of this PR. HiveThriftServer2 can run independently or be started with a SQL context: https://github.com/apache/spark/pull/18812/files#diff-709404b0d3defeff035ef0c4f5a960e5L57. For the later, this OOM should be handled by the upper layer, right? |
|
Can one of the admins verify this patch? |
Member
|
gentle ping @zuotingbing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refer to Hive, ThriftCLIService methods such as ExecuteStatement are apparently capable of catching OOMs because they get wrapped in RTE by HiveSessionProxy.This shouldn't happen.
I create a PR to fix this bug in Spark also.
How was this patch tested?
Exist tests and manual tests