[SPARK-21749][DOC] Add comments for MessageEncoder to explain the wire format#18965
[SPARK-21749][DOC] Add comments for MessageEncoder to explain the wire format#18965neoremind wants to merge 1 commit intoapache:masterfrom
Conversation
|
Can one of the admins verify this patch? |
|
@jerryshao please review my separated PR. Thanks! |
|
Seems you should add the |
|
We usually don't have the PRs which only add comments to explain something, so I'm neutral to this change. |
|
I see, anyway this is what I found when I dig into the wire protocol of spark rpc since wire format is a big part for understanding the message structure. If someone thinks this is not necessary I can close the PR. |
|
I think the more important question is, is it a protocol that we are guaranteeing? not sure that is. If not then I don't think it should be in user-facing docs. |
|
@srowen I see your concern, it is more internal oriented and maybe updated by developer as lib evolves, I will close the PR then. Thanks for reviewing! |
What changes were proposed in this pull request?
Spark RPC is built upon TCP tier and leverage netty framework. It would be better to have some comments in RPC module especially to explain the RPC message wire format since it is critical to understand what Message consists (header + payload). So Javadoc comments can be added into MessageEncoder class.
How was this patch tested?
Only comments added. Existing unit tests are all passed.