Skip to content

[SPARK-21849][Core]Make the serializer function more robust#19067

Closed
libratiger wants to merge 1 commit intoapache:masterfrom
libratiger:serializer
Closed

[SPARK-21849][Core]Make the serializer function more robust#19067
libratiger wants to merge 1 commit intoapache:masterfrom
libratiger:serializer

Conversation

@libratiger
Copy link

What changes were proposed in this pull request?

make sure the close function is called in the finally block.

How was this patch tested?

No Test, just compile.

@srowen
Copy link
Member

srowen commented Aug 28, 2017

There is no actual resource associated with the underlying stream anyway (it's a ByteArrayOutputStream) and it's closed in the normal flow anyway. I don't object, but it's the kind of thing that's generally too trivial to spend time proposing

@libratiger
Copy link
Author

Yes, I agree. it is better included in a normal pull request.

@SparkQA
Copy link

SparkQA commented Aug 29, 2017

Test build #3908 has finished for PR 19067 at commit b523ecb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Aug 29, 2017

If this doesn't fix anything and isn't making the code better or more consistent, it should be closed

@libratiger libratiger closed this Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants