[SPARK-21849][Core]Make the serializer function more robust#19067
Closed
libratiger wants to merge 1 commit intoapache:masterfrom
libratiger:serializer
Closed
[SPARK-21849][Core]Make the serializer function more robust#19067libratiger wants to merge 1 commit intoapache:masterfrom libratiger:serializer
libratiger wants to merge 1 commit intoapache:masterfrom
libratiger:serializer
Conversation
Member
|
There is no actual resource associated with the underlying stream anyway (it's a ByteArrayOutputStream) and it's closed in the normal flow anyway. I don't object, but it's the kind of thing that's generally too trivial to spend time proposing |
Author
|
Yes, I agree. it is better included in a normal pull request. |
|
Test build #3908 has finished for PR 19067 at commit
|
Member
|
If this doesn't fix anything and isn't making the code better or more consistent, it should be closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
make sure the
closefunction is called in thefinallyblock.How was this patch tested?
No Test, just compile.