[SPARK-21726][SQL][Follow-UP] Check for structural integrity of the plan in Optimzer in test mode#19161
Closed
viirya wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-21726][SQL][Follow-UP] Check for structural integrity of the plan in Optimzer in test mode#19161viirya wants to merge 1 commit intoapache:masterfrom
viirya wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
cc @gatorsmile |
Member
Author
|
also cc @cloud-fan |
|
Test build #81544 has finished for PR 19161 at commit
|
Member
Author
|
cc @HyukjinKwon if you are available now. If you are confident, can you help merge this? Should be straightforward. Thank you. |
Member
|
LGTM |
Member
|
Merged to master. |
Member
Author
|
Thanks @HyukjinKwon. Yeah, I want this to be merged quickly so it won't affect others build. |
Member
|
sigh... I did not catch it during the review... |
Member
Author
|
@gatorsmile Yeah...sorry not notice this too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The condition in
Optimizer.isPlanIntegralis wrong. We should always returntrueif not in test mode.How was this patch tested?
Manually test.