[HOTFIX][BUILD] Fix finalizer checkstyle error and re-disable checkstyle#19371
Closed
srowen wants to merge 1 commit intoapache:masterfrom
Closed
[HOTFIX][BUILD] Fix finalizer checkstyle error and re-disable checkstyle#19371srowen wants to merge 1 commit intoapache:masterfrom
srowen wants to merge 1 commit intoapache:masterfrom
Conversation
… checkstyle as it won't be run by SBT PR builder
Member
|
LGTM |
Contributor
|
+1 |
Contributor
|
Will merge to master when tests finish (not that they should be affected). |
|
Test build #82250 has finished for PR 19371 at commit
|
Contributor
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix finalizer checkstyle violation by just turning it off; re-disable checkstyle as it won't be run by SBT PR builder. See #18887 (comment)
How was this patch tested?
./dev/lint-javaruns successfully