[SPARK-21929][SQL] Support ALTER TABLE table_name ADD COLUMNS(..) for ORC data source#19545
Closed
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-21929
Closed
[SPARK-21929][SQL] Support ALTER TABLE table_name ADD COLUMNS(..) for ORC data source#19545dongjoon-hyun wants to merge 2 commits intoapache:masterfrom dongjoon-hyun:SPARK-21929
ALTER TABLE table_name ADD COLUMNS(..) for ORC data source#19545dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-21929
Conversation
…or ORC data source
|
Test build #82939 has finished for PR 19545 at commit
|
dongjoon-hyun
commented
Oct 21, 2017
| // Hive type is already considered as hive serde table, so the logic will not | ||
| // come in here. | ||
| case _: JsonFileFormat | _: CSVFileFormat | _: ParquetFileFormat => | ||
| case s if s.getClass.getCanonicalName.endsWith("OrcFileFormat") => |
Member
Author
There was a problem hiding this comment.
After implementing OrcFileFormat based on Apache ORC, we can move OrcFileFormat from sql/hive module into sql/core module.
Member
Author
|
Hi, @gatorsmile . Could you review this PR? |
gatorsmile
reviewed
Oct 21, 2017
| } | ||
| } | ||
|
|
||
| def testAddColumnPartitioned(provider: String): Unit = { |
gatorsmile
reviewed
Oct 21, 2017
| } | ||
| } | ||
|
|
||
| def testAddColumn(provider: String): Unit = { |
Member
|
LGTM |
Member
Author
|
Thank you for review, @gatorsmile ! I updated the PR. |
|
Test build #82942 has finished for PR 19545 at commit
|
Member
Author
|
Retest this please. |
|
Test build #82949 has finished for PR 19545 at commit
|
Member
Author
|
It’s ready for review again, @gatorsmile. Thanks. |
Member
|
Thanks! Merged to master. |
Member
Author
|
Thank you a lot, @gatorsmile ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When SPARK-19261 implements
ALTER TABLE ADD COLUMNS, ORC data source is omitted due to SPARK-14387, SPARK-16628, and SPARK-18355. Now, those issues are fixed and Spark 2.3 is using Spark schema to read ORC table instead of ORC file schema. This PR enablesALTER TABLE ADD COLUMNSfor ORC data source.How was this patch tested?
Pass the updated and added test cases.