[SPARK-21055][SQL][FOLLOW-UP] replace grouping__id with grouping_id()#19546
Closed
gatorsmile wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-21055][SQL][FOLLOW-UP] replace grouping__id with grouping_id()#19546gatorsmile wants to merge 1 commit intoapache:masterfrom
gatorsmile wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Test build #82943 has finished for PR 19546 at commit
|
Member
Author
|
retest this please |
|
Test build #82945 has finished for PR 19546 at commit
|
| @@ -1376,223 +1376,125 @@ class SQLQuerySuite extends QueryTest with SQLTestUtils with TestHiveSingleton { | |||
| } | |||
|
|
|||
| test("SPARK-8976 Wrong Result for Rollup #1") { | |||
Member
There was a problem hiding this comment.
Nit, do we need to keep SPARK-21055 in the test case name here, too?
Member
Author
There was a problem hiding this comment.
That is fine. We do not have such a rule.
Member
Author
|
Thanks! Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Simplifies the test cases that were added in the PR #18270.
How was this patch tested?
N/A