[SPARK-22133][DOCS] Documentation for Mesos Reject Offer Configurations

[windkit]

What changes were proposed in this pull request?

Documentation about Mesos Reject Offer Configurations

Related PR

#19510 for spark.mem.max

[skonto]

@susanxhuynh could you pls review this?

[ArtRand]

I would prefer that the spark.mem.max changes be a part of #19510 only. Just some nits w.r.t wording. Thanks for doing this!

[ArtRand]

Could you please add these changes only in #19510?

[windkit]

@ArtRand Sure, I will move the documentation to 19510

[ArtRand]

reserve is probably not the correct term to use here. I would use consume, as Spark does not actually make resource reservations http://mesos.apache.org/documentation/latest/reservation/

[windkit]

Agree. I will update it later on

[ArtRand]

As above, please add this in the separate PR.

[ArtRand]

This doesn't sound correct. The mesos.proto (https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L2310) states:

Time to consider unused resources refused. Note that all unused
resources will be considered refused and use the default value
(below) regardless of whether Filters was passed to
SchedulerDriver::launchTasks. You MUST pass Filters with this
field set to change this behavior (i.e., get another offer which
includes unused resources sooner or later than the default).

some simple word-smithing or a link should make it clearer.

[windkit]

Thanks for the comment, I will update it.

[ArtRand]

LGTM

[ArtRand]

Hey @srowen can we get a merge on this?

[SparkQA]

Test build #3984 has finished for PR 19555 at commit 5f3b35b.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

Merged to master